Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HOMEBREW_UPGRADE_GREEDY option #15160

Merged
merged 7 commits into from Apr 6, 2023
Merged

Add HOMEBREW_UPGRADE_GREEDY option #15160

merged 7 commits into from Apr 6, 2023

Conversation

razvanazamfirei
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix #15097, where discussion can be found.

Alternatively, this option could be modified to include all greedy options.

MikeMcQuaid
MikeMcQuaid reviewed Apr 5, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far!

Library/Homebrew/env_config.rb Outdated
@@ -344,6 +344,10 @@ module EnvConfig
description: "If set, use Pry for the `brew irb` command.",
boolean: true,
},
HOMEBREW_UPGRADE_GREEDY: {
description: "If set, run `--greedy` with all upgrade commands",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "If set, run `--greedy` with all upgrade commands",
description: "If set, pass `--greedy` to all cask upgrade commands",

What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, for consistency, I suggest adding a full stop here, too.

razvanazamfirei and others added 3 commits April 5, 2023 19:26
@razvanazamfirei
Update env_config.rb
87b4f1f
@razvanazamfirei @MikeMcQuaid
Update env_config.rb
acc598f 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@razvanazamfirei
syntax fix
22eb43c
@razvanazamfirei razvanazamfirei mentioned this pull request Apr 6, 2023
Closed
7 tasks
@MikeMcQuaid MikeMcQuaid merged commit 461fc3e into Homebrew:master Apr 6, 2023
24 checks passed
@MikeMcQuaid
Copy link
Member

Thanks again @razvanazamfirei, great work!

@reitermarkus reitermarkus changed the title Add HOMEBREW_GREEDY option Add HOMEBREW_UPGRADE_GREEDY option Apr 6, 2023
@razvanazamfirei razvanazamfirei mentioned this pull request Apr 6, 2023
Closed
6 tasks
@razvanazamfirei razvanazamfirei deleted the greedy branch April 13, 2023 03:12
@github-actions github-actions bot added the outdated PR was locked due to age label May 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HOMEBREW_GREEDY or variants
3 participants
@razvanazamfirei @MikeMcQuaid @ZhongRuoyu